Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update keystone.rst #12717

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
3 participants
@hrchu
Copy link
Contributor

hrchu commented Dec 30, 2016

Make it clear that project/domain options accept name instead of id.

@liewegas liewegas changed the title Update keystone.rst doc: Update keystone.rst Dec 30, 2016

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Dec 30, 2016

Please add the Signed-off-by: line tot he git commit message (see SubmittingPatches)

@hrchu hrchu force-pushed the hrchu:patch-1 branch from 18542b7 to 5361a77 Jan 2, 2017

@hrchu

This comment has been minimized.

Copy link
Contributor Author

hrchu commented Jan 2, 2017

@liewegas fixed.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jan 3, 2017

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it's "doc: ". or you can just use the title of "doc: Update keystone.rst".

doc: Update keystone.rst
Make it clear that project/domain options accept name instead of id.

Signed-off-by: Chu, Hua-Rong <hrchu@cht.com.tw>

@hrchu hrchu force-pushed the hrchu:patch-1 branch from 5361a77 to 70a7ef9 Jan 3, 2017

@hrchu

This comment has been minimized.

Copy link
Contributor Author

hrchu commented Jan 3, 2017

@tchaikov fixed, thanks for your reminder 👍

@tchaikov tchaikov merged commit 1397872 into ceph:master Jan 3, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.