New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/BitmapFreelistManager: readability improvements #12719

Merged
merged 3 commits into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@xiexingguo
Member

xiexingguo commented Dec 30, 2016

No description provided.

os/bluestore/BitmapFreelistManager: prefix "_" to get_offset() method
To keep pace with other private methods.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@liewegas

rest looks good!

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jan 10, 2017

Member

retest this please

Member

xiexingguo commented Jan 10, 2017

retest this please

xiexingguo added some commits Dec 30, 2016

os/bluestore/BitmapFreelistManager: formatting nits
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
os/bluestore/BitmapFreelistManager: readability improvements
Be slightly nice to who is looking at get_next_clear[set]_bit().

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jan 17, 2017

Member

@liewegas Any more comments?

Member

xiexingguo commented Jan 17, 2017

@liewegas Any more comments?

@liewegas liewegas merged commit a9bdb11 into ceph:master Jan 18, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bluestore-1229 branch Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment