New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/dev: update log_based_pg.rst, fix some display problem #12730

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
2 participants
@Liuchang0812
Contributor

Liuchang0812 commented Jan 1, 2017

Signed-off-by: liuchang0812 liuchang0812@gmail.com

3. Whether we choose the oldest or newest possible head entry
during peering
4. A bit of extra information in the log entry to enable rollback
1. How reads work -- async only, requires remote reads for ec

This comment has been minimized.

@tchaikov

tchaikov Jan 2, 2017

Contributor

could use

#. item 1
#. item 2

for ordered list

This comment has been minimized.

@Liuchang0812

Liuchang0812 Jan 2, 2017

Contributor

OK~ i'm working on this

This comment has been minimized.

@Liuchang0812

Liuchang0812 Jan 2, 2017

Contributor

done. I edit this on github's online editor. Need I squash these commits?

By the way. The ceph docuemnt website is broken. I sent a email to dev-maillist yesterday. It's still broken now.

This comment has been minimized.

@tchaikov

tchaikov Jan 2, 2017

Contributor

Need I squash these commits?

please do so.

and the first item is not changed yet.

By the way. The ceph docuemnt website is broken. I sent a email to dev-maillist yesterday. It's still broken now.

probably people are still on vacation?

This comment has been minimized.

@Liuchang0812

Liuchang0812 Jan 2, 2017

Contributor

Done.

😸 happy new year.

This comment has been minimized.

@tchaikov

tchaikov Jan 3, 2017

Contributor

happy new year to you!

PGBackend and PGTransaction enables abstraction of differences 1, 2,
#. All of the stats and metadata for objects
#. The high level locking rules for mixing client IO with recovery and scrub
#. The high level locking rules for mixing reads and writes without exposing uncommitted state (which might be rolled back or forgotten later)

This comment has been minimized.

@tchaikov

tchaikov Jan 2, 2017

Contributor

could you wrap the line at 80 chars?

This comment has been minimized.

@Liuchang0812

Liuchang0812 Jan 2, 2017

Contributor

how to make it? seems that RST‘s list doesn't support this.

This comment has been minimized.

@Liuchang0812

This comment has been minimized.

@Liuchang0812

This comment has been minimized.

@tchaikov

tchaikov Jan 3, 2017

Contributor

@Liuchang0812 for instance, you can simply put

#. How writes work -- either restricted to append, or must write aside
   and do a tpc

sphinx will render it just right. i tested locally. you can try using admin/build-doc to verify the generated html.

This comment has been minimized.

@Liuchang0812

Liuchang0812 Jan 3, 2017

Contributor

yes it works.

but Bullet Lists can't break lines, I use the line-blocks only for "-". Take a look please

doc/dev: update log_based_pg.rst, fix some display problem
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>

@tchaikov tchaikov merged commit 5438864 into ceph:master Jan 3, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov self-assigned this Jan 3, 2017

@Liuchang0812 Liuchang0812 deleted the Liuchang0812:fix-dev-doc-pglog branch Jan 3, 2017

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Jan 3, 2017

thanks for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment