New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code from .h into .cc #12737

Merged
merged 3 commits into from Jan 4, 2017

Conversation

Projects
None yet
3 participants
@amirv
Contributor

amirv commented Jan 2, 2017

Hi,

This pull request has some cosmetic changes to the RDMA code.
It has only copy-paste stuff (Except the last small patch) to make it easy to review.

last patch fixes a warning which is actually a small bug.

Thanks,
Amir

amirv added some commits Jan 2, 2017

RDMA: Move defenitions from Infiniband.h into .cc
Signed-off-by: Amir Vadai <amir@vadai.me>
RDMA: Move defenitions from RDMAStack.h into .cc
Signed-off-by: Amir Vadai <amir@vadai.me>
RDMA: Fix compilation warning
Infiniband.cc: In member function ‘int Infiniband::recv_msg(CephContext*, int, IBSYNMsg&)’:
Infiniband.cc:883:86: warning: format ‘%x’ expects argument of type ‘unsigned int*’, but argument 3 has type ‘uint16_t* {aka short unsigned int*}’ [-Wformat=]
     sscanf(msg, "%x:%x:%x:%x:%s", &(im.lid), &(im.qpn), &(im.psn),
     &(im.peer_qpn),gid);

Signed-off-by: Amir Vadai <amir@vadai.me>
@amirv

This comment has been minimized.

Contributor

amirv commented Jan 2, 2017

Adding @Adirl

@Adirl

This comment has been minimized.

Adirl commented Jan 2, 2017

@yuyuyu101 pls take a look
this is preparation for RDMA-CM

@yuyuyu101

This comment has been minimized.

Member

yuyuyu101 commented Jan 2, 2017

hmm, it's ok to me.. but I don't why we need to move all tiny implementation to .cc?

@amirv

This comment has been minimized.

Contributor

amirv commented Jan 2, 2017

Thanks @yuyuyu101

I moved only multiline functions to the .cc
At least in gvim, it makes things much clearer and easy to work on this way.

@Adirl

Adirl approved these changes Jan 4, 2017

make sure code compiles and msngr unittest pass

@yuyuyu101 yuyuyu101 merged commit 0940e7e into ceph:master Jan 4, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment