New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph_test_rados_api_watch_notify: move global variables into test class #12751

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Jan 3, 2017

so the class instances using mempool are destructed before the mempools
are destroyed. this avoids the "invalid read" issue reported by
valgrind.

Fixes: http://tracker.ceph.com/issues/18395
Signed-off-by: Kefu Chai kchai@redhat.com

ceph_test_rados_api_watch_notify: move global variables into test class
so the class instances using mempool are destructed before the mempools
are destroyed. this avoids the "invalid read" issue reported by
valgrind.

Fixes: http://tracker.ceph.com/issues/18395
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested a review from badone Jan 3, 2017

@badone badone self-assigned this Jan 3, 2017

@badone

badone approved these changes Jan 3, 2017

Test locally and LGTM. Thanks for your help on this buddy.

@badone badone merged commit a945407 into ceph:master Jan 3, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-18395 branch Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment