cmake: remove Findpciaccess.cmake #12776

Merged
merged 1 commit into from Jan 6, 2017

Projects

None yet

4 participants

@optimistyzy
Contributor

Now SPDK uses the DPDK's library for PCI device
enumeration, we can remove this dependency

Signed-off-by: optimistyzy optimistyzy@gmail.com

target_include_directories(os
PRIVATE
- ${DPDK_INCLUDE_DIR}
- ${PCIACCESS_INCLUDE_DIR})
+ ${DPDK_INCLUDE_DIR})
@tchaikov
tchaikov Jan 4, 2017 Contributor

then you might need to remove find_package(pciaccess REQUIRED) in CMakeLists.txt and #include <pciaccess.h> in NVMEDevice.h as well.

@optimistyzy
optimistyzy Jan 4, 2017 Contributor

Let me update it

@tchaikov tchaikov changed the title from cmake,modules: remove Findpciaccess.cmake to cmake: remove Findpciaccess.cmake Jan 4, 2017
@optimistyzy optimistyzy cmake,modules: remove Findpciaccess.cmake
Now SPDK uses the DPDK's library for PCI device
enumeration, we can remove this dependency

Signed-off-by: optimistyzy <optimistyzy@gmail.com>
52494f1
@tchaikov tchaikov added the cleanup label Jan 4, 2017
@liupan1111
Contributor

lgtm too.

@yuyuyu101 yuyuyu101 merged commit 836c568 into ceph:master Jan 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment