New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: remove Findpciaccess.cmake #12776

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
4 participants
@optimistyzy
Contributor

optimistyzy commented Jan 4, 2017

Now SPDK uses the DPDK's library for PCI device
enumeration, we can remove this dependency

Signed-off-by: optimistyzy optimistyzy@gmail.com

@optimistyzy

This comment has been minimized.

Contributor

optimistyzy commented Jan 4, 2017

target_include_directories(os
PRIVATE
${DPDK_INCLUDE_DIR}
${PCIACCESS_INCLUDE_DIR})
${DPDK_INCLUDE_DIR})

This comment has been minimized.

@tchaikov

tchaikov Jan 4, 2017

Contributor

then you might need to remove find_package(pciaccess REQUIRED) in CMakeLists.txt and #include <pciaccess.h> in NVMEDevice.h as well.

This comment has been minimized.

@optimistyzy

optimistyzy Jan 4, 2017

Contributor

Let me update it

@tchaikov tchaikov changed the title from cmake,modules: remove Findpciaccess.cmake to cmake: remove Findpciaccess.cmake Jan 4, 2017

cmake,modules: remove Findpciaccess.cmake
Now SPDK uses the DPDK's library for PCI device
enumeration, we can remove this dependency

Signed-off-by: optimistyzy <optimistyzy@gmail.com>

@tchaikov tchaikov added the cleanup label Jan 4, 2017

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jan 4, 2017

lgtm too.

@yuyuyu101 yuyuyu101 merged commit 836c568 into ceph:master Jan 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment