jewel: cephfs: lookup of /.. in jewel returns -ENOENT #12783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CEPH_INO_DOTDOT thing is quite strange. Under most OS (Linux included), the parent of the root is itself. IOW, at the root, '.' and '..' refer to the same inode. Change the ceph client to do the same, as this allows users to get valid stat info for '..', as well as elimnating some special-casing. Also in several places, we're checking dn_set.empty as an indicator of being the root. While that is true for the root, it's also true for unlinked directories. This patch has treats them the same. An unlinked directory will be reparented to itself, effectively acting as a root of its own. Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit 30d4ca0)
|
reviewed-by |
smithfarm
changed the title
|
@ukernel This PR passed an fs suite at http://tracker.ceph.com/issues/17851#note-39 with some valgrind issues, some of which can be ignored because they occurred on tcmalloc builds. That said, there is one valgrind issue in the MDS which resembles http://tracker.ceph.com/issues/5241 (28 MDSCacheObject occurrences). I see you reviewed the PR already - do you think this PR can be merged in spite of the above valgrind issue? |
|
@jcsp This passed a rados suite at http://tracker.ceph.com/issues/17851#note-45 with some (few, unrelated) failures, as well as an fs suite at http://tracker.ceph.com/issues/17851#note-49 with the usual (most likely benign) valgrind issues. OK to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/18413