New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrimaryLogPG: don't update digests for objects with mismatched names #12788

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
2 participants
@athanatos
Contributor

athanatos commented Jan 4, 2017

I've only seen this on one cluster, but let's not issue repops during
scrub on objects where the object_info_t::soid value is not correct.
The cluster in question has been through many different non-release
kernels and osd versions, so the objects presumably came about due to an
old xfs or filestore bug. They recently became fatal since we made
filestore crash on ENOENT for setattrs. In the past, the cluster just
silently tolerated them.

http://tracker.ceph.com/issues/18409 is a larger feature to detect these
better and repair them automatically.

Related: http://tracker.ceph.com/issues/18409
Signed-off-by: Samuel Just sjust@redhat.com

PrimaryLogPG: don't update digests for objects with mismatched names
I've only seen this on one cluster, but let's not issue repops during
scrub on objects where the object_info_t::soid value is not correct.
The cluster in question has been through many different non-release
kernels and osd versions, so the objects presumably came about due to an
old xfs or filestore bug.  They recently became fatal since we made
filestore crash on ENOENT for setattrs.  In the past, the cluster just
silently tolerated them.

http://tracker.ceph.com/issues/18409 is a larger feature to detect these
better and repair them automatically.

Related: http://tracker.ceph.com/issues/18409
Signed-off-by: Samuel Just <sjust@redhat.com>

@athanatos athanatos added this to the kraken milestone Jan 4, 2017

@athanatos athanatos requested a review from jdurgin Jan 4, 2017

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jan 4, 2017

Tested: http://pulpito.ceph.com/samuelj-2017-01-04_00:26:51-rados-wip-sam-testing---basic-smithi

Going to put on sepia to confirm that it prevents the crash.

@jdurgin

jdurgin approved these changes Jan 5, 2017

lgtm assuming it works in sepia

@athanatos athanatos merged commit 9d5fb72 into ceph:master Jan 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment