New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake: cleanup the use of udev and blkid in target_link_lib() #12811

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@wjwithagen
Contributor

wjwithagen commented Jan 6, 2017

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

if(HAVE_UDEV)
target_link_libraries(librbd LINK_PRIVATE
${UDEV_LIBRARIES})
endif()

This comment has been minimized.

@tchaikov

tchaikov Jan 6, 2017

Contributor

@wjwithagen i think we can drop udev here.

This comment has been minimized.

@wjwithagen

wjwithagen Jan 6, 2017

Contributor

@tchaikov
Let try...

Cmake: cleanup the use of udev and blkid in target_link_lib()
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

@tchaikov tchaikov added the needs-qa label Jan 6, 2017

@tchaikov tchaikov self-assigned this Jan 6, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jan 6, 2017

pushed to ceph-ci, and shaman builds fine.

@tchaikov tchaikov merged commit 9b430a8 into ceph:master Jan 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Jan 6, 2017

@tchaikov
Thanx,

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-rbd-udev-blkid branch Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment