New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVMEDevice: fix bug in data_buf_next_sge #12812

Merged
merged 1 commit into from Jan 8, 2017

Conversation

Projects
None yet
3 participants
@optimistyzy
Contributor

optimistyzy commented Jan 6, 2017

Also leverage spdk_zmalloc

Signed-off-by: optimistyzy optimistyzy@gmail.com

@yuyuyu101

This comment has been minimized.

Show comment
Hide comment
@yuyuyu101

yuyuyu101 Jan 6, 2017

Member

I think this is a refactor instead of bug?

Member

yuyuyu101 commented Jan 6, 2017

I think this is a refactor instead of bug?

@liupan1111

This comment has been minimized.

Show comment
Hide comment
@liupan1111

liupan1111 Jan 6, 2017

Contributor

@yuyuyu101, osd cannot be invoked without this change. We download The change and try, find it works well now.

Contributor

liupan1111 commented Jan 6, 2017

@yuyuyu101, osd cannot be invoked without this change. We download The change and try, find it works well now.

@yuyuyu101

This comment has been minimized.

Show comment
Hide comment
@yuyuyu101

yuyuyu101 Jan 7, 2017

Member

@optimistyzy could we update the commit message about why original codes matters?

Member

yuyuyu101 commented Jan 7, 2017

@optimistyzy could we update the commit message about why original codes matters?

NVMEDevice: Eliminate virt to physical address translation in data_bu…
…f_next_sge

After SPDK is updated, SPDK requires virtual address
instead of physical address in huge page memory. Thus,
we do not need to pass the physical address since SPDK
library will do the address translation work.If we
still use the original code, it seems a bug.

In this patch, we will also use spdk_zmalloc instead of
dpdk's rte_malloc_socket function.

Signed-off-by: optimistyzy <optimistyzy@gmail.com>
@optimistyzy

This comment has been minimized.

Show comment
Hide comment
@optimistyzy

optimistyzy Jan 8, 2017

Contributor

@yuyuyu101 updated.

Contributor

optimistyzy commented Jan 8, 2017

@yuyuyu101 updated.

@yuyuyu101 yuyuyu101 merged commit e3c54bc into ceph:master Jan 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@yuyuyu101

This comment has been minimized.

Show comment
Hide comment
@yuyuyu101

yuyuyu101 Jan 8, 2017

Member

thanks

Member

yuyuyu101 commented Jan 8, 2017

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment