New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw multisite: fix ref counting of completions #12841

Merged
merged 2 commits into from Jan 16, 2017

Conversation

Projects
None yet
2 participants
@cbodley
Contributor

cbodley commented Jan 9, 2017

fixes two cases where a RGWAioCompletionNotifier reference is leaked:

  • RGWCompletionManager::go_down() cancels registered notifiers, so they don't call back into unregister_completion_notifier() to drop their ref
  • RGWAsyncRadosRequest::finish() is called before send_request() can call notifier->cb() (which drops a ref)

cbodley added some commits Jan 4, 2017

rgw: RGWAsyncRadosRequest drops notifier ref on cancel
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@yehudasa

lgtm

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jan 16, 2017

teuthology results were green, except for a single valgrind failure in the osd and an s3test failure due to timeouts on slow requests

@yehudasa yehudasa merged commit 947d99a into ceph:master Jan 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@cbodley cbodley deleted the cbodley:wip-18407 branch Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment