New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/ReplicatedBackend: take read locks for clone sources during recovery #12844

Merged
merged 1 commit into from Jan 15, 2017

Conversation

Projects
None yet
2 participants
@athanatos
Contributor

athanatos commented Jan 9, 2017

Otherwise, we run the risk of a clone source which hasn't actually
come into existence yet being used if we grab a clone which just
got added the the ssc, but has not yet actually had time to be
created (can't rely on message ordering here since recovery messages
don't necessarily order with client IO!).

Fixes: http://tracker.ceph.com/issues/17831
Signed-off-by: Samuel Just sjust@redhat.com

@athanatos athanatos added this to the kraken milestone Jan 9, 2017

ReplicatedBackend: take read locks for clone sources during recovery
Otherwise, we run the risk of a clone source which hasn't actually
come into existence yet being used if we grab a clone which *just*
got added the the ssc, but has not yet actually had time to be
created (can't rely on message ordering here since recovery messages
don't necessarily order with client IO!).

Fixes: http://tracker.ceph.com/issues/17831
Signed-off-by: Samuel Just <sjust@redhat.com>
@athanatos

This comment has been minimized.

Contributor

athanatos commented Jan 13, 2017

retest this please

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jan 13, 2017

@athanatos athanatos changed the title from DNM(needs testing): ReplicatedBackend: take read locks for clone sources during recovery to osd/ReplicatedBackend: take read locks for clone sources during recovery Jan 13, 2017

@athanatos athanatos requested review from liewegas and jdurgin Jan 13, 2017

@athanatos athanatos removed the needs-qa label Jan 13, 2017

@jdurgin

lgtm, surprising small for a change like this

@athanatos athanatos merged commit f634eb3 into ceph:master Jan 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment