New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: refactor exclusive lock support into generic managed lock #12846

Merged
merged 9 commits into from Jan 11, 2017

Conversation

Projects
None yet
3 participants
@dillaman
Contributor

dillaman commented Jan 9, 2017

No description provided.

rjfd and others added some commits Nov 4, 2016

rbd: Implementation of a generic object watcher class
Signed-off-by: Ricardo Dias <rdias@suse.com>
rbd: Implementation of a generic managed-lock
Signed-off-by: Ricardo Dias <rdias@suse.com>
rbd: ImageWatcher refactoring using Watcher super class
Signed-off-by: Ricardo Dias <rdias@suse.com>
rbd: added unit tests for new managed-lock implementation
Signed-off-by: Ricardo Dias <rdias@suse.com>
librbd: merge managed lock refactor
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: rewatch complete callback should be invoked w/o lock
It's currently being incorrectly invoked twice -- but the direct
callback is holding the Watcher lock. This results in a recursive
lock when ManagedLock attempts to retrieve the watch id from the
Watcher.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: potential nullptr dereference in ManagedLock
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@dillaman

This comment has been minimized.

@trociny trociny self-assigned this Jan 10, 2017

@trociny trociny requested a review from rjfd Jan 10, 2017

@trociny

This comment has been minimized.

Contributor

trociny commented Jan 10, 2017

@ceph-jenkins retest this please

@rjfd

rjfd approved these changes Jan 10, 2017

LGTM

@dillaman dillaman merged commit 5341e1f into ceph:master Jan 11, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-rbd-mirror-ha-merge branch Jan 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment