New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: shrink buffer_map key into uint32_t #12850

Merged
merged 1 commit into from Jan 10, 2017

Conversation

Projects
None yet
3 participants
@xiexingguo
Member

xiexingguo commented Jan 10, 2017

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@@ -215,7 +215,7 @@ class BlueStore : public ObjectStore,
boost::intrusive::list_member_hook<>,
&Buffer::state_item> > state_list_t;
mempool::bluestore_meta_other::map<uint64_t, std::unique_ptr<Buffer>>
mempool::bluestore_meta_other::map<uint32_t, std::unique_ptr<Buffer>>

This comment has been minimized.

@ifed01

ifed01 Jan 10, 2017

Contributor

Most probably this brings no benefit too due to struct alignment/allocation granularity issues I highlighted above. But it might still worth fixing for the sake of logical offset type consistency over the code.

@ifed01

ifed01 Jan 10, 2017

Contributor

Most probably this brings no benefit too due to struct alignment/allocation granularity issues I highlighted above. But it might still worth fixing for the sake of logical offset type consistency over the code.

This comment has been minimized.

@xiexingguo

xiexingguo Jan 10, 2017

Member

Done. Thanks!

@xiexingguo

xiexingguo Jan 10, 2017

Member

Done. Thanks!

@xiexingguo xiexingguo changed the title from os/bluestore: reduce Buffer's in-memory footprint to os/bluestore: shrink buffer_map key into uint32_t Jan 10, 2017

os/bluestore: shrink buffer_map key into uint32_t
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@liewegas liewegas merged commit c96cb2d into ceph:master Jan 10, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bluestore-20170110 branch Jan 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment