New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: finish clientreplay requests before requesting active state #12852

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Projects
None yet
3 participants
@ukernel
Member

ukernel commented Jan 10, 2017

All clientreplay requests' finish contexts should be executed
before MDCache::export_remaining_imported_caps(). Otherwise
MDCache::try_reconnect_cap() may fail to reconnect client caps.

Fixes: http://tracker.ceph.com/issues/18461
Signed-off-by: Yan, Zheng zyan@redhat.com

mds: finish clientreplay requests before requesting active state
All clientreplay requests' finish contexts should be executed
before MDCache::export_remaining_imported_caps(). Otherwise
MDCache::try_reconnect_cap() may fail to reconnect client caps.

Fixes: http://tracker.ceph.com/issues/18461
Signed-off-by: Yan, Zheng <zyan@redhat.com>
@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jan 11, 2017

Did this just pop up because of some of the other recent ordering changes?
(And presumably need to go into Kraken as well, assuming it's the correct fix?)

@ukernel

This comment has been minimized.

Member

ukernel commented Jan 12, 2017

I think it's a longstanding bug

@gregsfortytwo

Reviewed-by: Greg Farnum gfarnum@redhat.com

@jcsp jcsp merged commit 72103cf into ceph:master Jan 13, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@ukernel ukernel deleted the ukernel:wip-18461 branch Feb 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment