New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: kill BufferSpace.empty() #12871

Merged
merged 1 commit into from Jan 11, 2017

Conversation

Projects
None yet
2 participants
@xiexingguo
Member

xiexingguo commented Jan 11, 2017

Because:

  1. All other public methods are called under the protection of cache->lock,
    which makes the usage of this method is weird.

  2. The only caller is _dump_extent_map(), and we can do it without this
    in a simpler way.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

os/bluestore: kill BufferSpace.empty()
Because:
1. All other public methods are called under the protection of cache->lock,
which makes the usage of this method is weird.

2. The only caller is _dump_extent_map(), and we can do it without this
in a simpler way.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@liewegas liewegas added the bluestore label Jan 11, 2017

@liewegas liewegas merged commit ab9d375 into ceph:master Jan 11, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-bluestore-20170111 branch Jan 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment