New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: use Best-Effort policy when evicting onode from cache #12876

Merged
merged 1 commit into from Jan 15, 2017

Conversation

Projects
None yet
3 participants
@xiexingguo
Member

xiexingguo commented Jan 11, 2017

We want a precise control of cache usage, and BE can achieve this goal
in a better way.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Jan 11, 2017

Member

So, my concern here, and the reason it does what it does, is that I was worried about a situation where we have lots of onodes that still have refs and trim ends up iterating over N pinned entries each time it is called.

Perhaps we can add in a second threshold so that we only iterate over a limited number of pinned entries before giving up so that we don't spend too much CPU time? bluestore_cache_trim_max_skip_pinned or something along those lines?

Member

liewegas commented Jan 11, 2017

So, my concern here, and the reason it does what it does, is that I was worried about a situation where we have lots of onodes that still have refs and trim ends up iterating over N pinned entries each time it is called.

Perhaps we can add in a second threshold so that we only iterate over a limited number of pinned entries before giving up so that we don't spend too much CPU time? bluestore_cache_trim_max_skip_pinned or something along those lines?

os/bluestore: use Best-Effort policy when evicting onode from cache
We want a precise control of cache usage, and BE can achieve this goal
in a better way.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jan 12, 2017

Member

Updated.

Member

xiexingguo commented Jan 12, 2017

Updated.

@liewegas liewegas merged commit a5fcd3a into ceph:master Jan 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@xiexingguo xiexingguo deleted the xiexingguo:xxg-wip-be-for-cache branch Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment