New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: nullptr in OmapIteratorImpl::valid #12900

Merged
merged 1 commit into from Jan 15, 2017

Conversation

Projects
None yet
2 participants
@XinzeChi
Member

XinzeChi commented Jan 12, 2017

call stack:
SnapMapper::get_next_object_to_trim -> MapCacher::get_next ->
OSDriver::get_next-> BlueStore::OmapIteratorImpl::valid()

In OSDriver::get_next, it call iter->upper_bound(key); // this may reset it to nullptr

Signed-off-by: Xinze Chi xinze@xsky.com

@XinzeChi XinzeChi changed the title from BlueStore: nullptr in OmapIteratorImpl::valid to os/bluestore: nullptr in OmapIteratorImpl::valid Jan 12, 2017

os/bluestore: nullptr in OmapIteratorImpl::valid
call stack:
SnapMapper::get_next_object_to_trim -> MapCacher::get_next ->
OSDriver::get_next-> BlueStore::OmapIteratorImpl::valid()

In OSDriver::get_next, it call iter->upper_bound(key); // this may reset it to nullptr

Signed-off-by: Xinze Chi <xinze@xsky.com>

@liewegas liewegas added the needs-qa label Jan 12, 2017

@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Jan 12, 2017

Member

Can you construct a test for store_test.cc that triggers this case?

Member

liewegas commented Jan 12, 2017

Can you construct a test for store_test.cc that triggers this case?

@liewegas liewegas merged commit 7cca268 into ceph:master Jan 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment