Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: misc fixes detected by crypto shutdown assert #12925

Merged
merged 4 commits into from Jan 16, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Copy link
Member

liewegas commented Jan 13, 2017

These are fixes uncovered by #12624, without the assert on shutdown that
helped find them (since not all leaks have been found yet).

liewegas added some commits Dec 22, 2016

mon/MonClient: use std::unique_ptr<>; fix leak
We were leaking several heap items from
LibRadosMiscConnectFailure.ConnectFailure when connect() was called
multiple times (after failure).  Use std::unique_ptr to avoid maintaining
fragile cleanup paths.

Signed-off-by: Sage Weil <sage@redhat.com>
unittest_crypto: fix leaks
Signed-off-by: Sage Weil <sage@redhat.com>
global/signal_handler: behave if g_ceph_context or _log are null
This can happen if we trigger an assertion while g_ceph_context is being
torn down.

Signed-off-by: Sage Weil <sage@redhat.com>
global/signal_handler: dump backtrace even from within logging code
We can dump the backtrace regardless of where we hit the assertion.

Signed-off-by: Sage Weil <sage@redhat.com>
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jan 13, 2017

test this please

@badone

badone approved these changes Jan 15, 2017

Copy link
Contributor

badone left a comment

Looks good to me

ostringstream oss;
bt.print(oss);
dout_emergency(oss.str());

This comment has been minimized.

Copy link
@badone

badone Jan 15, 2017

Contributor

Just a thought here. Would this code benefit from Kefu's PR 9028 ?

@liewegas

This comment has been minimized.

Copy link
Member Author

liewegas commented Jan 16, 2017

@yuriw yuriw merged commit 12a1e20 into ceph:master Jan 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.