Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Enhancement for the supported auth methods #12937

Merged
merged 1 commit into from Jan 25, 2017

Conversation

Projects
None yet
2 participants
@chendave
Copy link
Contributor

chendave commented Jan 16, 2017

  • If no auth protocol defined, cephx is used by default, it's debatable if
    ceph should abort here or use cephx by default, but if cephx is used
    in this case it's better to give some warning message.
  • ceph has CEPH_AUTH_UNKNOWN auth protocol defined, change to use this
    protocol if the auth method is unknown.

Signed-off-by: Dave Chen wei.d.chen@intel.com

auth: Enhancement for the supported auth methods
- If no auth protocol defined, `cephx` is used by default, it's debatable if
  ceph should abort here or use `cephx` by default, but if `cephx` is used
  in this case it's better to give some warning message.
- ceph has CEPH_AUTH_UNKNOWN auth protocol defined, change to use this
  protocol if the auth method is unknown.

Signed-off-by: Dave Chen <wei.d.chen@intel.com>
@chendave

This comment has been minimized.

Copy link
Contributor Author

chendave commented Jan 16, 2017

@neuhalje, now it seems more clear. :)

@liewegas liewegas added the needs-qa label Jan 16, 2017

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Jan 16, 2017

Looks good, thanks!

@liewegas liewegas merged commit 84ae7d2 into ceph:master Jan 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.