New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osdc: cache should ignore error bhs during trim #12966

Merged
merged 1 commit into from Jan 31, 2017

Conversation

Projects
None yet
3 participants
@dillaman
Contributor

dillaman commented Jan 17, 2017

A read error (such as injecting a timeout into an OSD op) might result
in a bh in an error state. These should be trimable by the cache.

Fixes: http://tracker.ceph.com/issues/18436
Signed-off-by: Jason Dillaman dillaman@redhat.com

osdc: cache should ignore error bhs during trim
A read error (such as injecting a timeout into an OSD op) might result
in a bh in an error state. These should be trimable by the cache.

Fixes: http://tracker.ceph.com/issues/18436
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jan 18, 2017

Since you tagged this as CephFS, LGTM at a quick glance.

@jcsp

jcsp approved these changes Jan 27, 2017

@jcsp

This comment has been minimized.

Contributor

jcsp commented Jan 27, 2017

@dillaman this passed the fs suite here: http://pulpito.ceph.com/jspray-2017-01-27_11:40:25-fs-wip-jcsp-testing-20170126-distro-basic-smithi, did you also want to run the rbd suite against it?

@dillaman

This comment has been minimized.

Contributor

dillaman commented Jan 27, 2017

@jcsp I included this in an rbd suite run w/ another PR and no issues popped up (at least related to this PR).

@dillaman dillaman merged commit 3d894ca into ceph:master Jan 31, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-18436 branch Jan 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment