Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: remove unnecessary dependencies of ManagedLock #12982

Merged
merged 3 commits into from Jan 20, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Copy link
Contributor

dillaman commented Jan 18, 2017

No description provided.

@dillaman dillaman force-pushed the dillaman:wip-18524 branch from 7ec1f6e to 58ed9a4 Jan 18, 2017

dillaman added some commits Jan 17, 2017

librbd: removed ManagedLock dependency from ancillary classes
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
test: separate testing of exclusive lock from managed lock
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: clean up pre-release lock handling
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman force-pushed the dillaman:wip-18524 branch from 58ed9a4 to 7b62e5e Jan 18, 2017

@trociny trociny self-assigned this Jan 19, 2017

@trociny

This comment has been minimized.

Copy link
Contributor

trociny commented Jan 19, 2017

@ceph-jenkins retest this please

@trociny
Copy link
Contributor

trociny left a comment

LGTM

@trociny trociny merged commit 709198a into ceph:master Jan 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-18524 branch Jan 20, 2017

@@ -170,18 +215,18 @@ class ManagedLock {
std::string m_cookie;
std::string m_new_cookie;

State m_state;

This comment has been minimized.

Copy link
@trociny

trociny Jan 21, 2017

Contributor

@dillaman Just noticed, there are compilation warnings due to wrong initialization order in the constructor

This comment has been minimized.

Copy link
@dillaman

dillaman Jan 21, 2017

Author Contributor

Addressed in PR #13042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.