Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: adding PerfCounters for backoff throttle #13017

Merged
merged 1 commit into from Feb 13, 2017

Conversation

Projects
None yet
4 participants
@chuanhong-wang
Copy link
Contributor

chuanhong-wang commented Jan 20, 2017

Signed-off-by: Chuanhong wangchuanhong.wang@163.com

@chuanhong-wang

This comment has been minimized.

Copy link
Contributor Author

chuanhong-wang commented Jan 21, 2017

@xiexingguo please help me review code

@@ -251,6 +251,57 @@ void Throttle::reset()
}
}

enum {
l_backoff_throttle_first = l_throttle_last+1,

This comment has been minimized.

Copy link
@xiexingguo

xiexingguo Jan 22, 2017

Member

space before and after "+"

@@ -539,8 +539,8 @@ FileStore::FileStore(CephContext* cct, const std::string &base,
next_osr_id(0),
m_disable_wbthrottle(cct->_conf->filestore_odsync_write ||
!cct->_conf->filestore_wbthrottle_enable),
throttle_ops(cct->_conf->filestore_caller_concurrency),
throttle_bytes(cct->_conf->filestore_caller_concurrency),
throttle_ops(g_ceph_context, "filestore_ops", cct->_conf->filestore_caller_concurrency),

This comment has been minimized.

Copy link
@xiexingguo

xiexingguo Jan 22, 2017

Member

Can we use cct here instead?

throttle_ops(cct->_conf->filestore_caller_concurrency),
throttle_bytes(cct->_conf->filestore_caller_concurrency),
throttle_ops(g_ceph_context, "filestore_ops", cct->_conf->filestore_caller_concurrency),
throttle_bytes(g_ceph_context, "filestore_bytes", cct->_conf->filestore_caller_concurrency),

This comment has been minimized.

Copy link
@xiexingguo

This comment has been minimized.

Copy link
@chuanhong-wang

chuanhong-wang Feb 8, 2017

Author Contributor

@xiexingguo done, please help me review again

@xiexingguo

This comment has been minimized.

Copy link
Member

xiexingguo commented Jan 22, 2017

Looks good except some nits

osd: adding PerfCounters for backoff throttle
Signed-off-by: Chuanhong Wang <chuanhong.wang@163.com>

@xiexingguo xiexingguo added the needs-qa label Feb 8, 2017

@yuriw yuriw merged commit df2e1fd into ceph:master Feb 13, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.