New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mailmap: Willem Jan Withagen affiliation #13034

Merged
merged 1 commit into from Feb 14, 2017

Conversation

Projects
None yet
5 participants
@wjwithagen
Contributor

wjwithagen commented Jan 20, 2017

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@wjwithagen wjwithagen requested a review from batrick Jan 28, 2017

@batrick batrick removed their request for review Jan 31, 2017

@tchaikov tchaikov removed the core label Feb 8, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 8, 2017

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it's "mailmap: ".

@tchaikov tchaikov requested a review from theanalyst Feb 8, 2017

@tchaikov tchaikov changed the title from Affiliation updates to mailmap: Willem Jan Withagen affiliation Feb 8, 2017

@theanalyst

theanalyst approved these changes Feb 8, 2017 edited

@theanalyst

There is another affiliation in organization map (for digiware) if it is a change of organization, you need an entry in peoplemap as well

@theanalyst

There is another affiliation in organization map (for digiware) if it is a change of organization, you need an entry in peoplemap as well

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Feb 9, 2017

@theanalyst
I actaully work for 2 companies: digiware and nefos.
Both are paying my bills currently.
Looking at the content of the organisationmap, it looks like there are more people in the same situation?

@theanalyst theanalyst requested a review from Feb 10, 2017

@theanalyst

This comment has been minimized.

Member

theanalyst commented Feb 10, 2017

@wjwithagen ah ok, I assumed it was a change of companies, then it is ok, I believe we don't need an entry in the .peoplemap then, I also think the mailmap entry is not needed here and only the organizationmap would suffice, as otherwise all the digiware commits would show up as nefos, without the mailmap entry it would show up as two seperate organizations depending on the email, which is what you want. I could be wrong, I'll let @dachary confirm.

@ghost

This comment has been minimized.

ghost commented Feb 10, 2017

I confirm.

@ghost

ghost approved these changes Feb 10, 2017

Affiliation updates
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

@liewegas liewegas merged commit 293c766 into ceph:master Feb 14, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-brag branch Feb 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment