New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/rgw: fixes for test_multi_period_incremental_sync() #13067

Merged
merged 3 commits into from Apr 26, 2017

Conversation

Projects
None yet
2 participants
@cbodley
Contributor

cbodley commented Jan 23, 2017

test was only creating objects in subsequent periods, which wasn't adding any entries to the mdlog. this wasn't correctly testing incremental metadata sync across periods

# wait for zone 1 to sync
realm.zone_meta_checkpoint(realm.get_zone('us-1'))
# change master back to zone 1 -> period 3
realm.set_master_zone(realm.get_zone('us-1'))
for zone, bucket_name in zone_bucket.items():
# create another bucket in each zone, except for z3
for zone in realm.get_zones():
if zone == z3:

This comment has been minimized.

@yehudasa

yehudasa Jan 25, 2017

Member

@cbodley are we assuming this test runs with at least 3 zones?

This comment has been minimized.

@cbodley

cbodley Jan 25, 2017

Contributor

yes, the test is skipped if there are less than 3:

def test_multi_period_incremental_sync():
    if len(realm.clusters) < 3:
        from nose.plugins.skip import SkipTest
        raise SkipTest("test_multi_period_incremental_sync skipped. Requires 3 or more clusters.")

@cbodley cbodley referenced this pull request Jan 25, 2017

Merged

rgw multisite: automated mdlog trimming #13111

2 of 2 tasks complete
@yehudasa

lgtm

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 22, 2017

added a time.sleep(5) to set_master_zone() to resolve a race between period commit and later metadata operations

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 28, 2017

@yehudasa thoughts on merging this before the fixes in #13070? the mdlog trimming pr at #13111 has changes to test_multi.py that depend on this

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 10, 2017

rebased over multi-zonegroup changes. still passing against #13070

@yehudasa

This comment has been minimized.

Member

yehudasa commented Apr 10, 2017

@cbodley feel free to merge at your convenience

cbodley added some commits Apr 25, 2017

test/rgw: meta checkpoint compares realm epoch
avoid marker comparisons between different periods

Signed-off-by: Casey Bodley <cbodley@redhat.com>
test/rgw: fixes for test_multi_period_incremental_sync()
test was only creating objects in subsequent periods, which wasn't
adding any entries to the mdlog. this wasn't correctly testing
incremental metadata sync across periods

Signed-off-by: Casey Bodley <cbodley@redhat.com>
test/rgw: wait for realm reload after set_master_zone
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 25, 2017

rebased, will merge on build check

@cbodley

This comment has been minimized.

Contributor

cbodley commented Apr 25, 2017

jenkins test this please

@cbodley cbodley merged commit aae4c18 into ceph:master Apr 26, 2017

3 of 4 checks passed

arm build Build triggered. sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@cbodley cbodley deleted the cbodley:wip-rgw-test-multi-periods branch Apr 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment