New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush: verify weights is influenced by the number of replicas #13083

Merged
merged 1 commit into from Jan 24, 2017

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Jan 24, 2017

Refs: http://tracker.ceph.com/issues/15653

Signed-off-by: Adam C. Emerson aemerson@redhat.com
Signed-off-by: Loic Dachary loic@dachary.org

@ghost ghost added the tests label Jan 24, 2017

@ghost ghost requested review from liewegas and adamemerson Jan 24, 2017

@ghost

This comment has been minimized.

ghost commented Jan 24, 2017

grep "device \(0\|4\)" | sed -e 's/^.*stored : \([0-9]\+\).*$/\1/'))
if test $(echo "scale=5; (10 - ${old[0]}/${old[1]}) < .75" | bc) = 1; then
echo Untweaked weights better distributed than they should be. 1>&2

This comment has been minimized.

@liewegas

liewegas Jan 24, 2017

Member

this message doesn't make sense outside of adam's proposed fix. otherwise lgtm!

This comment has been minimized.

@liewegas

liewegas Jan 24, 2017

Member

also, perhaps the test should do the same thing with num-rep 1 and verify the ratio is in the expected range

@ghost

This comment has been minimized.

ghost commented Jan 24, 2017

Addressed sage comments (fixed the error message and added a test for replica 1), chmod +x and repushed.

crush: verify weights is influenced by the number of replicas
Refs: http://tracker.ceph.com/issues/15653

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Signed-off-by: Loic Dachary <loic@dachary.org>

@liewegas liewegas merged commit 3140a52 into ceph:master Jan 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment