New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/PrimaryLogPG::try_lock_for_read: give up if missing #13087

Merged
merged 1 commit into from Jan 26, 2017

Conversation

Projects
None yet
3 participants
@athanatos
Contributor

athanatos commented Jan 24, 2017

The only users calc_*_subsets might try to read_lock an object which is
missing on the primary. Returning false in those cases is perfectly
reasonable and avoids the problem.

Fixes: http://tracker.ceph.com/issues/18583
Signed-off-by: Samuel Just sjust@redhat.com

PrimaryLogPG::try_lock_for_read: give up if missing
The only users calc_*_subsets might try to read_lock an object which is
missing on the primary.  Returning false in those cases is perfectly
reasonable and avoids the problem.

Fixes: http://tracker.ceph.com/issues/18583
Signed-off-by: Samuel Just <sjust@redhat.com>

@athanatos athanatos requested a review from jdurgin Jan 24, 2017

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jan 24, 2017

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jan 25, 2017

retest this please

@liewegas liewegas self-assigned this Jan 25, 2017

@liewegas liewegas changed the title from PrimaryLogPG::try_lock_for_read: give up if missing to osd/PrimaryLogPG::try_lock_for_read: give up if missing Jan 25, 2017

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jan 25, 2017

retest this please

@athanatos

This comment has been minimized.

Contributor

athanatos commented Jan 26, 2017

@jdurgin I think this is good to go.

@jdurgin jdurgin merged commit fa0311e into ceph:master Jan 26, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment