New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18600: Clear out tasks that don't make sense from multimds suite #13089

Merged
merged 3 commits into from Feb 14, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Contributor

jcsp commented Jan 24, 2017

I've gone a little further than just removing the quota, to also remove the very basic tests that it seems wasteful to run in the multimds suite as well as the fs suite

John Spray added some commits Jan 24, 2017

John Spray
qa: break out tasks/ in multimds suite
...so that we can selectively disable those
which are not appropriate for multimds testing, or
which are not kclient compatible (all multimds workunits
run against both kclient and fuse).

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
qa: disable quota tests in multimds
Quotas don't work with kclient, and multimds tasks
are run against kclient.  We don't need to run this
against fuse here because it's a basic correctness
test that's run against fuse in the fs suite.

Fixes: http://tracker.ceph.com/issues/18600
Signed-off-by: John Spray <john.spray@redhat.com>
@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jan 25, 2017

My concern here is that it's an explicit mapping of what tests we want to run in multi-mds, which means we have to remember to opt-in when building new tests.
It would require a teuthology PR but did we consider setting up an opt-out instead, by either changing the names or creating a "whiteout" directory combination?

@jcsp

This comment has been minimized.

Contributor

jcsp commented Feb 1, 2017

I'm not motivated to add that feature to teuthology, because on the long run I'm not sure we're really going to maintain these as two side by side suites -- once multimds suite is stable and multi-mds systems are the norm, I'm imagining cutting the "fs" suite back to something more minimal, and all the real long running workload tests would run in multi-mds configurations.

@jcsp jcsp changed the title from #18600: Clear out tasks that don't make sense from multidms suite to #18600: Clear out tasks that don't make sense from multimds suite Feb 1, 2017

John Spray
qa: remove simple functional tests from multimds
These were running so few ops that they weren't
giving any meaningful exercise to a multimds
system beyond what we're already covering in
the fs suite.

Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp merged commit dfbc675 into ceph:master Feb 14, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-18600 branch Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment