New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Document that osd_heartbeat_grace applies to MON and OSD #13098

Merged
merged 1 commit into from Jan 30, 2017

Conversation

Projects
None yet
4 participants
@wido
Member

wido commented Jan 25, 2017

This value has to be set in both the [mon] and [osd] section since
both daemons read this value.

Signed-off-by: Wido den Hollander wido@42on.com

@wido wido added the documentation label Jan 25, 2017

@wido wido requested a review from jcsp Jan 25, 2017

@tchaikov tchaikov self-assigned this Jan 25, 2017

period by adding an ``osd heartbeat grace`` setting under the ``[osd]`` section
of your Ceph configuration file, or by setting the value at runtime.
period by adding an ``osd heartbeat grace`` setting under the ```[mon]```
and ``[osd]`` section of your Ceph configuration file, or by setting the

This comment has been minimized.

@jecluis

jecluis Jan 25, 2017

Member

setting in [global] will apply to both osds and mons, btw. Maybe worth mentioning that as well. Same for the description section in the other chunk of the patch.

@wido

This comment has been minimized.

Member

wido commented Jan 25, 2017

Thanks @jecluis! I pushed a new version of the patch. Care to review?

@tchaikov tchaikov removed their assignment Jan 26, 2017

period by adding an ``osd heartbeat grace`` setting under the ``[osd]`` section
of your Ceph configuration file, or by setting the value at runtime.
period by adding an ``osd heartbeat grace`` setting under the ```[mon]```
and ``[osd]`` or ```[global]```section of your Ceph configuration file,

This comment has been minimized.

@jdurgin

jdurgin Jan 28, 2017

Member

triple backticks should only be double around [global] and [mon]

doc: Document that osd_heartbeat_grace applies to MON and OSD
This value has to be set in both the [mon] and [osd] section since
both daemons read this value.

Signed-off-by: Wido den Hollander <wido@42on.com>
@wido

This comment has been minimized.

Member

wido commented Jan 30, 2017

Thanks @jdurgin, updated commit pushed

@jdurgin jdurgin merged commit c26f317 into ceph:master Jan 30, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment