New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks: force umount during kclient teardown #13099

Merged
merged 2 commits into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Contributor

jcsp commented Jan 25, 2017

Previously we could readily end up hanging on teardown
when something had gone wrong with umount. Forcing
is a big hammer (umount_wait will power cycle the node
if umount isn't working), so if we had to do that
then raise an exception to indicate that something
was wrong with the test.

Fixes: http://tracker.ceph.com/issues/18663
Signed-off-by: John Spray john.spray@redhat.com

@jcsp jcsp added cephfs tests labels Jan 25, 2017

for mount in mounts.values():
if mount.is_mounted():
try:
mount.umount()

This comment has been minimized.

@ukernel

ukernel Jan 25, 2017

Member

I think this umount still can hang. how about adding a timeout

John Spray added some commits Jan 25, 2017

John Spray
qa/tasks: force umount during kclient teardown
Previously we could readily end up hanging on teardown
when something had gone wrong with umount.  Forcing
is a big hammer (umount_wait will power cycle the node
if umount isn't working), so if we had to do that
then raise an exception to indicate that something
was wrong with the test.

Fixes: http://tracker.ceph.com/issues/18663
Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
tasks/kclient: apply timeout to umount
The umount process can get stuck, in which case
we want to fail the test rather than waiting around for it.

During teardown of the kclient task catch this
timeout explicitly so that we will powercycle the node if
needed.

Signed-off-by: John Spray <john.spray@redhat.com>
@jcsp

This comment has been minimized.

Contributor

jcsp commented Feb 10, 2017

@jcsp jcsp merged commit a3fd3f2 into ceph:master Feb 10, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@jcsp jcsp deleted the jcsp:wip-18663 branch Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment