Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
librbd: deferred image deletion #13105
2 times, most recently
Feb 1, 2017
@rjfd Last night I was thinking that perhaps we might want to add some sort of "source" enum for who initiated the move to the trash. My thought is that rbd-mirror should always move an image to the trash and its image deleter process should periodically attempt to remove any items in the trash (that aren't being delayed) if the source is set to "rbd-mirror". Otherwise, if rbd-mirror is running, it would potentially start deleting images in the trash that a user moved to the trash -- and it might get confusing.
dillaman left a comment
I think we might also want some way to force-delete an image that has a deferred deletion time specified (i.e. I fat-fingered a very large time) -- perhaps a new API method that deletes a specific image from the trash (by id) w/ and optional "--force" optional
@dillaman regarding your comment about deleting an image that the deferred time hasn't expired yet, the current
Should I change this behavior to only delete when the deferment time has expired, or when passing an explicit force value?
@dillaman Can you clarify this point? are you talking about supporting deletion of deferred images at the librbd only, or also using the CLI using the