New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: prevent self-blacklisting during break lock #13110

Merged
merged 1 commit into from Jan 26, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Jan 25, 2017

Fixes: http://tracker.ceph.com/issues/18666
Signed-off-by: Jason Dillaman dillaman@redhat.com

librbd: prevent self-blacklisting during break lock
Fixes: http://tracker.ceph.com/issues/18666
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@trociny trociny self-assigned this Jan 26, 2017

@trociny

This comment has been minimized.

Contributor

trociny commented Jan 26, 2017

@dillaman just wondering, it looks it would be safer to check address. Do you check entity because there is no rados API for get_myaddr?

Also, if we are breaking without blacklisting, is it ok to self-break?

@dillaman

This comment has been minimized.

Contributor

dillaman commented Jan 26, 2017

@trociny The client id is a globally unique identifier (and the only one available to us) and the lock itself is attached to the client global id, not its IP address. Do you have a case in mind where this would fail?

We aren't introducing any additional worries if you disabled blacklisting and you attempted to self-break. In that case, it would at least be able to recover the lock (unlike if it blacklisted itself).

@trociny

This comment has been minimized.

Contributor

trociny commented Jan 26, 2017

@dillaman

Do you have a case in mind where this would fail?

Never mind, I forgot that the address also includes nonce. I was thinking that if an application had two clients, their addresses would match (which is not the case, and actually then our BreakLock tests would not work).

@trociny

LGTM

@trociny trociny merged commit c720e34 into ceph:master Jan 26, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-18666 branch Jan 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment