Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
librbd: prevent self-blacklisting during break lock #13110
@trociny The client id is a globally unique identifier (and the only one available to us) and the lock itself is attached to the client global id, not its IP address. Do you have a case in mind where this would fail?
We aren't introducing any additional worries if you disabled blacklisting and you attempted to self-break. In that case, it would at least be able to recover the lock (unlike if it blacklisted itself).
Never mind, I forgot that the address also includes nonce. I was thinking that if an application had two clients, their addresses would match (which is not the case, and actually then our BreakLock tests would not work).