New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: we know the definite epoch of marking down #13121

Merged
merged 1 commit into from Feb 7, 2017

Conversation

Projects
None yet
3 participants
@LiumxNL
Contributor

LiumxNL commented Jan 26, 2017

Signed-off-by: Mingxin Liu mingxin@xsky.com

@@ -7137,7 +7137,7 @@ void OSD::_committed_osd_maps(epoch_t first, epoch_t last, MOSDMap *m)
if (service.is_preparing_to_stop() || service.is_stopping()) {
service.got_stop_ack();
} else {
clog->warn() << "map e" << osdmap->get_epoch()
clog->warn() << "map e" << osdmap->get_down_at(whoami)

This comment has been minimized.

@tchaikov

tchaikov Jan 26, 2017

Contributor

could put:

clog->warn() << "map e" << osdmap->get_epoch()
 		        << " wrongly marked me down at"
 		        << osdmap->get_down_at(whoami);

otherwise this log line would be missleading. because osdmap->get_down_at(whoami) is not the epoch of the osdmap being digested.

@tchaikov tchaikov added the core label Jan 26, 2017

osd: we know the definite epoch of marking down
Signed-off-by: Mingxin Liu <mingxin@xsky.com>
@LiumxNL

This comment has been minimized.

Contributor

LiumxNL commented Feb 1, 2017

retest this please

@LiumxNL

This comment has been minimized.

Contributor

LiumxNL commented Feb 1, 2017

@tchaikov tchaikov self-assigned this Feb 4, 2017

@tchaikov tchaikov added the needs-qa label Feb 4, 2017

@yuriw yuriw merged commit 1a8e353 into ceph:master Feb 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment