New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Fix broken async/rdma compilation since move to libceph-common #13122

Merged
merged 1 commit into from Jan 26, 2017

Conversation

Projects
None yet
5 participants
@orendu
Contributor

orendu commented Jan 26, 2017

Was broken since merge of pull request #12840

Signed-off-by: Oren Duer oren@mellanox.com

@orendu

This comment has been minimized.

Contributor

orendu commented Jan 26, 2017

@amirv

amirv approved these changes Jan 26, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jan 26, 2017

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes. in this case, it would be "cmake: ".

@tchaikov tchaikov added the build/ops label Jan 26, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jan 26, 2017

modulo the prefix of commit message title, lgtm

cmake: Fix broken async/rdma compilation since move to libceph-common
Was broken since merge of pull request #12840

Signed-off-by: Oren Duer <oren@mellanox.com>
@Adirl

Adirl approved these changes Jan 26, 2017

@yuyuyu101 yuyuyu101 requested a review from tchaikov Jan 26, 2017

@tchaikov tchaikov merged commit 4755086 into ceph:master Jan 26, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov self-assigned this Jan 26, 2017

@orendu orendu deleted the orendu:fix-rdma-compilation branch Jan 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment