Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: use separate waitlist for scrub #13136

Merged
merged 1 commit into from Feb 1, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

liewegas commented Jan 26, 2017

No description provided.

@liewegas liewegas self-assigned this Jan 26, 2017

@liewegas liewegas changed the title osd: wait for scrub after degraded, unreadable DNM: osd: wait for scrub after degraded, unreadable Jan 26, 2017

@liewegas

This comment has been minimized.

Copy link
Member Author

liewegas commented Jan 26, 2017

testing this in isolation

@liewegas liewegas force-pushed the liewegas:wip-scrub-waitlist branch 3 times, most recently from b61e1c1 to bb7618b Jan 27, 2017

@liewegas liewegas changed the title DNM: osd: wait for scrub after degraded, unreadable osd: use separate waitlist for scrub Jan 27, 2017

@liewegas liewegas requested a review from athanatos Jan 27, 2017

@liewegas liewegas force-pushed the liewegas:wip-scrub-waitlist branch from bb7618b to fc915eb Jan 30, 2017

osd: use distinct wait list for scrub
We've traditionally (ab)used waiting_for_active for ops blocked
by scrub.  In order to preserve the op requeue ordering for
backoffs relating to unreadable and degraded, however, we need
to order the scrub waits different.  The first step is to have it
on its own list.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-scrub-waitlist branch from fc915eb to 7a803bf Jan 31, 2017

@liewegas

This comment has been minimized.

@liewegas

This comment has been minimized.

@athanatos

This comment has been minimized.

Copy link
Contributor

athanatos commented Feb 1, 2017

LGTM

@liewegas liewegas merged commit 4a71a8a into ceph:master Feb 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-scrub-waitlist branch Feb 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.