New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: fix race in Mount.open_background #13137

Merged
merged 2 commits into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Contributor

jcsp commented Jan 26, 2017

Previously a later remote call could end up executing
before the remote python program in open_background
had actually got as far as opening the file.

Fixes: http://tracker.ceph.com/issues/18661
Signed-off-by: John Spray john.spray@redhat.com

qa: fix race in Mount.open_background
Previously a later remote call could end up executing
before the remote python program in open_background
had actually got as far as opening the file.

Fixes: http://tracker.ceph.com/issues/18661
Signed-off-by: John Spray <john.spray@redhat.com>
@ukernel

This comment has been minimized.

Member

ukernel commented Jan 26, 2017

For test_open_inode, the file exists before the background open. I think we need change the order of write_n_mb() and background_open()

tasks/cephfs: switch open vs. write in test_open_inode
Do the write after opening the file, so that we get good
behaviour wrt the change in Mount.open_background that uses
file existence to confirm that the open happened.

Signed-off-by: John Spray <john.spray@redhat.com>
@ukernel

ukernel approved these changes Feb 2, 2017

@jcsp

This comment has been minimized.

@jcsp jcsp merged commit 880cbf0 into ceph:master Feb 10, 2017

2 of 3 checks passed

default Build finished.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@jcsp jcsp deleted the jcsp:wip-18661 branch Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment