New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: fix statfs to not include DB partition in free space #13140

Merged
merged 1 commit into from Jan 27, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jan 26, 2017

If we report the DB space as vailable, ceph thinks the OSD can store more
data and will not mark the cluster as full as easily. And in reality, we
can't actually store data in this space--only metadata. Avoid the problem
by not reporting it as available.

Fixes: http://tracker.ceph.com/issues/18599
Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas requested a review from ifed01 Jan 26, 2017

os/bluestore: fix statfs to not include DB partition in free space
If we report the DB space as vailable, ceph thinks the OSD can store more
data and will not mark the cluster as full as easily.  And in reality, we
can't actually store data in this space--only metadata.  Avoid the problem
by not reporting it as available.

Fixes: http://tracker.ceph.com/issues/18599
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Show comment
Hide comment
@liewegas

liewegas Jan 26, 2017

Member

Ah, on vstart the db partition is tiny (64mb) which is why it wasn't obvious this was working.

Member

liewegas commented Jan 26, 2017

Ah, on vstart the db partition is tiny (64mb) which is why it wasn't obvious this was working.

@ifed01

ifed01 approved these changes Jan 27, 2017

@liupan1111

This comment has been minimized.

Show comment
Hide comment
@liupan1111

liupan1111 Jan 27, 2017

Contributor

@liewegas , our QA also finds this issue, thanks for the fix!

Contributor

liupan1111 commented Jan 27, 2017

@liewegas , our QA also finds this issue, thanks for the fix!

@liewegas liewegas merged commit b88b29e into ceph:master Jan 27, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-bluestore-statfs branch Jan 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment