New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librbd: introduce new constants for tracking max block name prefix #13141

Merged
merged 1 commit into from Jan 30, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Contributor

dillaman commented Jan 26, 2017

Fixes: http://tracker.ceph.com/issues/18653
Signed-off-by: Jason Dillaman dillaman@redhat.com

@trociny trociny requested a review from idryomov Jan 27, 2017

* v1 format: rb.<max 8-byte high id>.<max 8-byte low id>.<max 8-byte extra>
* v2 format: rbd_data.[<max 19-byte pool id>.]<max 14-byte image id>
*/
#define RBD_MAX_BLOCK_NAME_PREFIX_LENGTH 43

This comment has been minimized.

@idryomov

idryomov Jan 30, 2017

Contributor

Perhaps RBD_MAX_OBJECT_PREFIX_LENGTH, so that it matches the method name? I'd also mention that it might change in the future when new features are added.

This comment has been minimized.

@dillaman

dillaman Jan 30, 2017

Contributor

The new API methods are rbd_get_block_name_prefix and Image::get_block_name_prefix.

This comment has been minimized.

@idryomov

idryomov Jan 30, 2017

Contributor

I see -- just wanted to avoid BLOCK_NAME_SIZE vs a greater BLOCK_NAME_PREFIX_LENGTH.
Want to update the comment?

@dillaman

This comment has been minimized.

Contributor

dillaman commented Jan 30, 2017

@idryomov updated

@idryomov idryomov merged commit 326a113 into ceph:master Jan 30, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@dillaman dillaman deleted the dillaman:wip-18653 branch Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment