New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: extend ObjectStore interface to dump store's performance counters #13203

Merged
merged 5 commits into from Feb 1, 2017

Conversation

Projects
None yet
3 participants
@ifed01
Contributor

ifed01 commented Jan 31, 2017

No description provided.

Igor Fedotov added some commits Jan 31, 2017

Igor Fedotov
test/fio: fix misordered parameter for queue_transaction.
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Igor Fedotov
os/bluestore: fix typos in perf counter public names.
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>

@ifed01 ifed01 changed the title from test/fio: add store's performance counters dump on completion to os: extend ObjectStore interface to dump store's performance counters Jan 31, 2017

Igor Fedotov added some commits Jan 31, 2017

Igor Fedotov
os: add dump_perf_counters method to ObjectStore implementations.
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Igor Fedotov
test/fio: add performance counters dump on FIO job completion.
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Igor Fedotov
os/bluestore: add submit latency perf counter.
Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Jan 31, 2017

Contributor

hi, @ifed01 Where will it be used? We will provide a command in OSD's asock?

Contributor

Liuchang0812 commented Jan 31, 2017

hi, @ifed01 Where will it be used? We will provide a command in OSD's asock?

@ifed01

This comment has been minimized.

Show comment
Hide comment
@ifed01

ifed01 Jan 31, 2017

Contributor

@Liuchang0812 - An opportunity to access performance counters via admin sockets (and hence from CLI) already exists.
See http://docs.ceph.com/docs/giant/dev/perf_counters/
This patch is needed for fio objectstore plugin. And probably makes sense for other testing tools and unit tests that lack command interfaces.

Contributor

ifed01 commented Jan 31, 2017

@Liuchang0812 - An opportunity to access performance counters via admin sockets (and hence from CLI) already exists.
See http://docs.ceph.com/docs/giant/dev/perf_counters/
This patch is needed for fio objectstore plugin. And probably makes sense for other testing tools and unit tests that lack command interfaces.

@Liuchang0812

This comment has been minimized.

Show comment
Hide comment
@Liuchang0812

Liuchang0812 Jan 31, 2017

Contributor

@ifed01 sounds great! thanks for your explanation.

Contributor

Liuchang0812 commented Jan 31, 2017

@ifed01 sounds great! thanks for your explanation.

@liewegas liewegas added the needs-qa label Feb 1, 2017

@liewegas liewegas merged commit 09d23e8 into ceph:master Feb 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@ifed01 ifed01 deleted the ifed01:wip-bluestore-more-dump branch Feb 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment