Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: be aware abount tenants on cls_user_bucket -> rgw_bucket conversion #13220

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
2 participants
@rzarzynski
Copy link
Contributor

rzarzynski commented Feb 1, 2017

This is a simplified fix for issue 18364. It bases on the assumption that links between user and buckets can't cross the tenant boundary. There is no change to the underlying Ceph classes. Thus, the fix should easily portable to Jewel and Kraken and I don't expect any upgrade-related issues.

Accounting became operational for tenanted users:

$ bin/radosgw-admin user stats --uid 2987047fc47840058e89e6182e0d96c3\$2987047fc47840058e89e6182e0d96c3 --sync-stats
...
{
    "stats": {
        "total_entries": 8,
        "total_bytes": 642,
        "total_bytes_rounded": 32768
    },
    "last_stats_sync": "2017-02-01 18:51:19.471956Z",
    "last_stats_update": "2017-02-01 18:51:19.467099Z"
}

Tempest nor s3-tests hasn't found any regression here.

Fixes: http://tracker.ceph.com/issues/18364
Derogates: #12710
Is-Related-To: #12709
CC: @yehudasa, @oritwas, @cbodley.

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Feb 2, 2017

does this address http://tracker.ceph.com/issues/16355 from the original pr #9938?

@rzarzynski

This comment has been minimized.

Copy link
Contributor Author

rzarzynski commented Feb 2, 2017

@rzarzynski

This comment has been minimized.

Copy link
Contributor Author

rzarzynski commented Feb 2, 2017

@cbodley: I think so. Although I haven't tried the --tenant switch of radosgw-admin, the same effect should come by supplying --uid with tenant and user part separated by $.

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Feb 2, 2017

@rzarzynski okay, thanks - can you add a Fixed: http://tracker.ceph.com/issues/16355 to your commit so we can close it out too?

@rzarzynski rzarzynski force-pushed the rzarzynski:wip-rgw-18364-2 branch from 0af777e to 871e1f5 Feb 2, 2017

@rzarzynski

This comment has been minimized.

Copy link
Contributor Author

rzarzynski commented Feb 2, 2017

@cbodley: no problem. Just pushed the amended version. Thanks for pointing this out!

@rzarzynski

This comment has been minimized.

Copy link
Contributor Author

rzarzynski commented Feb 3, 2017

I went through the Teuthology results. The 3 failures seem to be unrelated to the change.

@cbodley

cbodley approved these changes Feb 3, 2017

@cbodley cbodley merged commit 0f1e08c into ceph:master Feb 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.