New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: swift: fix anonymous user's error code of getting object #13242

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
2 participants
@Jing-Scott
Contributor

Jing-Scott commented Feb 3, 2017

The openstack swift will return 401 rather than 403 when the anon user has no permission to get objects.

Fixes: http://tracker.ceph.com/issues/18806
Signed-off-by: Jing Wenjun jingwenjun@cmss.chinamobile.com

@rzarzynski rzarzynski self-assigned this Feb 3, 2017

@rzarzynski

Looks good. I will merge this after testing.

@@ -17,6 +17,7 @@ class RGWGetObj_ObjStore_SWIFT : public RGWGetObj_ObjStore {
RGWGetObj_ObjStore_SWIFT() {}
~RGWGetObj_ObjStore_SWIFT() {}
int verify_permission() override;

This comment has been minimized.

@rzarzynski

rzarzynski Feb 3, 2017

Contributor

I'm 100% behind the override. Thanks!

@rzarzynski

This comment has been minimized.

@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Feb 6, 2017

@Jing-Scott: the results look OK. Could you please alter the commit message to have:

  • a new line between the commit's title and its description,
  • lines wrapped before 80th column?

I mean something like this example below:

rgw: swift: fix anonymous user's error code of getting object

The openstack swift will return 401 rather than 403 when
the anon user has no permission to get objects.
    
Fixes: http://tracker.ceph.com/issues/18806
Signed-off-by: Jing Wenjun <jingwenjun@cmss.chinamobile.com>
rgw: swift: fix anonymous user's error code of getting object
The openstack swift will return 401 rather than 403 when
the anon user has no permission to get objects.

Fixes: http://tracker.ceph.com/issues/18806
Signed-off-by: Jing Wenjun <jingwenjun@cmss.chinamobile.com>
@Jing-Scott

This comment has been minimized.

Contributor

Jing-Scott commented Feb 6, 2017

@rzarzynski : okay, no problem! done :)

@rzarzynski rzarzynski merged commit 7511564 into ceph:master Feb 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Feb 6, 2017

@Jing-Scott: merged. Thanks!

@Jing-Scott Jing-Scott deleted the Jing-Scott:dev/fix-swift-anon-getobj-error-code branch Feb 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment