New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librados: do not expose non-public symbols #13265

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Feb 5, 2017

librados could be referencing the wrong symbol when calling the
destructor. for example, a variable of type AioGetxattrsData in
IoCtxImpl.cc) could be destructed using the destructor defined in
librados.cc. this is reproduciable using

ceph_test_rados_api_aio --gtest_filter=LibRadosAio.XattrIter

Signed-off-by: Kefu Chai kchai@redhat.com

librados: do not expose non-public symbols
librados could be referencing the wrong symbol when calling the
destructor. for example, a variable of type AioGetxattrsData in
IoCtxImpl.cc) could be destructed using the destructor defined in
librados.cc. this is reproduciable using

ceph_test_rados_api_aio --gtest_filter=LibRadosAio.XattrIter

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested a review from jdurgin Feb 5, 2017

@jdurgin

jdurgin approved these changes Feb 7, 2017

@jdurgin jdurgin added the needs-qa label Feb 7, 2017

@tchaikov tchaikov self-assigned this Feb 7, 2017

@tchaikov tchaikov merged commit 38f3d74 into ceph:master Feb 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-librados-hide-private-symbols branch Feb 8, 2017

@tchaikov

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment