New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: do not throw TypeError on connection failure #13268

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Feb 6, 2017

otherwise we could concat None with a string on connection problem.
which will result in TypeError. and the caller will print misleading
error like

Error connecting to cluster: TypeError

see also #12934

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added the core label Feb 6, 2017

@tchaikov tchaikov requested review from jecluis, jdurgin and dmick Feb 6, 2017

@tchaikov tchaikov changed the title from ceph: do not throw TypeError on on connection failure to ceph: do not throw TypeError on connection failure Feb 6, 2017

ceph: do not throw TypeError on connection failure
otherwise we could concat None with a string on connection problem.
which will result in TypeError. and the caller will print misleading
error like

Error connecting to cluster: TypeError

see also #12934

Signed-off-by: Kefu Chai <kchai@redhat.com>

@liewegas liewegas added the needs-qa label Feb 6, 2017

@jdurgin

jdurgin approved these changes Feb 6, 2017

@tchaikov tchaikov self-assigned this Feb 7, 2017

@tchaikov tchaikov merged commit 4071387 into ceph:master Feb 8, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-better-error-ping-mon branch Feb 8, 2017

@tchaikov

This comment has been minimized.

hjwsm1989 pushed a commit to hjwsm1989/ceph that referenced this pull request Feb 23, 2017

client: added permission check based on getgrouplist
Fixes: ceph#13268
Signed-off-by: Yan, Zheng <zyan@redhat.com>
(cherry picked from commit f04c8da)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment