New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Have install put manpages in the FreeBSD correct location #13301

Merged
merged 1 commit into from Feb 16, 2017

Conversation

Projects
None yet
2 participants
@wjwithagen
Contributor

wjwithagen commented Feb 7, 2017

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@@ -163,7 +163,11 @@ CHECK_STRUCT_HAS_MEMBER("struct stat" st_mtim.tv_nsec sys/stat.h
CHECK_STRUCT_HAS_MEMBER("struct stat" st_mtimespec.tv_nsec sys/stat.h
HAVE_STAT_ST_MTIMESPEC_TV_NSEC LANGUAGE C)
set(CEPH_MAN_DIR "share/man" CACHE STRING "Install location for man pages (relative to prefix).")
if(FREEBSD)
set(CEPH_MAN_DIR "man" CACHE STRING "Install location for man pages (relative to prefix).")

This comment has been minimized.

@tchaikov

tchaikov Feb 8, 2017

Contributor

there is no need to define this in CMakeLists.txt. instead, you might want to pass -DCEPH_MAN_DIR=man in do_freebsd.sh.

This comment has been minimized.

@wjwithagen

wjwithagen Feb 8, 2017

Contributor

@tchaikov
Reasons I did it this way are:

  1. Don't really know if ever anybody is going to rumage thru the CACHE looking for the STRING.
  2. The ports building does not use ./do_freeBSD.sh because the way external sources are accessed is not how it should be done in port.
    But I can do this in the ports Makefile
  3. This is a rather permanent fix for building on FreeBSD, and I'm using the stuff in the do_freebsd.sh script more for that can change in the future. And it fixes it for all build environments at once, I currently have: Ceph, jenkins, ports, pouderiere.

So I would really appreciate it to go here.

This comment has been minimized.

@tchaikov

tchaikov Feb 15, 2017

Contributor

Don't really know if ever anybody is going to rumage thru the CACHE looking for the STRING.

it's maintainer's job to set the right path to comply to the platform/distro's policy/convention. i guess he/she should be familiar with the setting. if not, he/she can always ask the upstream (us) for help.

This is a rather permanent fix for building on FreeBSD

there are many settings combinations are permanent to different architecture / platform / distros, what we are offering is to make this possible and even easier to majority of our users. i'd want to avoid filling the cmake script with different combinations on all of these settings even they are permanent to their targeting platforms.

@tchaikov tchaikov added the build/ops label Feb 8, 2017

@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Feb 15, 2017

@tchaikov
Oke, I'll adjust the PR and fix it in ./do_freebsd.sh, the ports Makefile and my Jenkins builders.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Feb 16, 2017

@wjwithagen thanks for understanding.

@wjwithagen wjwithagen closed this Feb 16, 2017

@wjwithagen wjwithagen reopened this Feb 16, 2017

doc: Have install put manpages in the FreeBSD correct location
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@wjwithagen

This comment has been minimized.

Contributor

wjwithagen commented Feb 16, 2017

@tchaikov
Moved it into ./do_freebsd.sh

@tchaikov tchaikov merged commit 2c249cc into ceph:master Feb 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov self-assigned this Feb 16, 2017

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-freebsd-manpage-location branch Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment