New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph.spec.in, debian/control: Add bc to build dependencies #13338

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
3 participants
@kshtsk
Contributor

kshtsk commented Feb 9, 2017

The bc is missing for ceph-helpers.sh

Fixes: http://tracker.ceph.com/issues/18876
Signed-off-by: Kyr Shatskyy kyrylo.shatskyy@gmail.com

@kshtsk kshtsk closed this Feb 9, 2017

@kshtsk kshtsk reopened this Feb 9, 2017

@kshtsk

This comment has been minimized.

Contributor

kshtsk commented Feb 9, 2017

@smithfarm could you please review this patch

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Feb 9, 2017

@kshtsk Could you open a bug at http://tracker.ceph.com describing the problem this is fixing?

Then, add a line to the commit message (directly above Signed-off-by: line) like this:

Fixes: http://tracker.ceph.com/issues/$ISSUE_NUMBER

Thanks

@smithfarm smithfarm self-assigned this Feb 9, 2017

@smithfarm smithfarm changed the title from Add bc to ceph spec to build/ops: rpm: Add bc to ceph spec Feb 9, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented Feb 9, 2017

@kshtsk Also need to add the build dep to debian/control Thanks

@dmick

This comment has been minimized.

Member

dmick commented Feb 9, 2017

  1. is this not also a build dependency for debian? (edit: oops nathan already asked)
  2. it would also be nice if PR title and commit title were clearer: "ceph.spec.in, debian/control: Add bc to build dependencies".

@smithfarm smithfarm requested a review from dmick Feb 9, 2017

ceph.spec.in, debian/control: Add bc to build dependencies
The bc is missing for ceph-helpers.sh

Fixes: http://tracker.ceph.com/issues/18876
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>

@kshtsk kshtsk changed the title from build/ops: rpm: Add bc to ceph spec to ceph.spec.in, debian/control: Add bc to build dependencies Feb 9, 2017

@dmick

dmick approved these changes Feb 10, 2017

lgtm

@smithfarm smithfarm merged commit 9bd91dc into ceph:master Feb 10, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment