Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg/simple/Pipe: support IPv6 QoS. #13370

Merged
merged 1 commit into from Feb 16, 2017

Conversation

Projects
None yet
5 participants
@robbat2
Copy link
Contributor

robbat2 commented Feb 11, 2017

Extend DSCP marking for heartbeat packets to IPv6, as commit
9b9a682 only implemented
support for IPv4.

Backport: jewel, luminious
Fixes: http://tracker.ceph.com/issues/18887
Signed-off-by: Robin H. Johnson robin.johnson@dreamhost.com

msg/simple/Pipe: support IPv6 QoS.
Extend DSCP marking for heartbeat packets to IPv6, as commit
9b9a682 only implemented
support for IPv4.

Backport: jewel, luminious
Fixes: http://tracker.ceph.com/issues/18887
Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>

@robbat2 robbat2 force-pushed the dreamhost:wip-18887 branch from 84c6d2e to 2d6021f Feb 11, 2017

@robbat2

This comment has been minimized.

Copy link
Contributor Author

robbat2 commented Feb 11, 2017

This needs to be implemented in src/msg/async/net_handler.cc as well, but it's a little bit harder to get the address family there.

@badone

badone approved these changes Feb 11, 2017

Copy link
Contributor

badone left a comment

LGTM

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Feb 13, 2017

@yuyuyu101 should we do this for msg/async too?

@yuyuyu101

This comment has been minimized.

Copy link
Member

yuyuyu101 commented Feb 13, 2017

sure, this can go ahead. I could supply async codes later

@robbat2

This comment has been minimized.

Copy link
Contributor Author

robbat2 commented Feb 13, 2017

@yuyuyu101 I started on the async path, but the address family isn't available in the NetHandler::set_priority (only the fd and prio are passed in), and I'm wondering if you have an opinion on what you'd like passed into that function for it.

@yuyuyu101

This comment has been minimized.

Copy link
Member

yuyuyu101 commented Feb 14, 2017

@robbat2 hmm, I think we can add new argument for set_priority and passing family into

@robbat2

This comment has been minimized.

Copy link
Contributor Author

robbat2 commented Feb 14, 2017

async version is here: #13418

@tchaikov tchaikov merged commit 42d4bf7 into ceph:master Feb 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.