Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: change the conditional in _update_calc_stats #13383

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
3 participants
@wonzhq
Copy link
Contributor

commented Feb 13, 2017

'in_up' and 'in_acting' exposes the internal logic of choose_acting.
The code to calculate missing/misplaced objects needs to be changed
as well when there is a change in choosing acting. Change to use
'is_backfill_targets' to avoid this.

Signed-off-by: Zhiqiang Wang zhiqiang@xsky.com

Zhiqiang Wang
osd: change the conditional in _update_calc_stats
'in_up' and 'in_acting' exposes the internal logic of choose_acting.
The code to calculate missing/misplaced objects needs to be changed
as well when there is a change in choosing acting. Change to use
'is_backfill_targets' to avoid this.

Signed-off-by: Zhiqiang Wang <zhiqiang@xsky.com>

@tchaikov tchaikov self-assigned this Feb 13, 2017

// recovery Compute total objects excluding num_missing
// - not in up Compute misplaced objects excluding num_missing
// backfill Compute total objects already backfilled
if (!is_backfill_targets(p)) {

This comment has been minimized.

Copy link
@tchaikov

tchaikov Sep 6, 2017

Contributor

yeah, the following sets are equal:

[shard for shard in actingbackfill if actingset.count(p)]

and

[shard for shard in actingbackfill if !is_backfill_targets(p)]
@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2017

retest this please.

@tchaikov tchaikov merged commit 985978e into ceph:master Sep 12, 2017

7 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.