New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: link consumers of libclient with libcommon #13394

Merged
merged 2 commits into from Feb 14, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Feb 13, 2017

No description provided.

tchaikov added some commits Feb 13, 2017

cmake: link consumers of libclient with libcommon
to avoid linking against to both libceph-common and libcommon at the same
time, because both of them will be registered as a provider of lttng
provider.

Fixes: http://tracker.ceph.com/issues/18838
Signed-off-by: Kefu Chai <kchai@redhat.com>
ceph-fuse: always free allocated fuse_args
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested a review from jcsp Feb 13, 2017

}
void usage()
{
cout <<

This comment has been minimized.

@badone

badone Feb 14, 2017

Contributor

Should this be its own separate PR? Seems unrelated to the linking changes.

This comment has been minimized.

@tchaikov

tchaikov Feb 14, 2017

Contributor

the PR tries to fix the mem leak issues reported by valgrind, that's why i think this cleanup could be part of it.

This comment has been minimized.

@badone

badone Feb 14, 2017

Contributor

OK. That's probably worth a mention in the commit message?

This comment has been minimized.

@badone

badone Feb 14, 2017

Contributor

Doh! Of course the tracker mentions them. Sorry @tchaikov

@badone

badone approved these changes Feb 14, 2017

LGTM

@jcsp jcsp merged commit 71938e3 into ceph:master Feb 14, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@jcsp

This comment has been minimized.

Contributor

jcsp commented Feb 14, 2017

@tchaikov tchaikov deleted the tchaikov:wip-18838 branch Feb 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment