New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document RGW quota cache options #13395

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
6 participants
@dang
Contributor

dang commented Feb 13, 2017

Quota cache options were undocumented. Issue #18747

Signed-off-by: Daniel Gryniewicz dang@redhat.com

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented Feb 13, 2017

Mind updating the commit message to use the standard? When commit messages refer to bare numbers like that, GitHub associates it with PRs :(

Refs: http://tracker.ceph.com/issues/18747

@vumrao

This comment has been minimized.

Contributor

vumrao commented Feb 13, 2017

@dang default is very high for option rgw_user_quota_sync_interval.

OPTION(rgw_user_quota_sync_interval, OPT_INT, 3600 * 24) // time period for accumulating modified buckets before syncing entire user stats

and I have tested with the setting value of options rgw_bucket_quota_ttl and rgw_user_quota_bucket_sync_interval as 0 and it worked fine.

@vumrao

This comment has been minimized.

Contributor

vumrao commented Feb 13, 2017

I have tested all three options:

rgw_bucket_quota_ttl = 0
rgw_user_quota_bucket_sync_interval = 0
rgw_user_quota_sync_interval = 0

as value zero and have same effect. Quota is working properly with two RGW instances in HA Proxy round-robin. So good to have all three marked as zero.

I think we just need to change the default value of rgw_user_quota_sync_interval from 180 to 3600*24.

@@ -352,6 +352,35 @@ Ceph configuration file, the default value will be set automatically.
:Default: ``false``
``rgw bucket quota ttl``
:Description: The amount of time in seconds cached quota information it

This comment has been minimized.

@cbodley

cbodley Feb 15, 2017

Contributor

quota information it

quota information is

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Mar 2, 2017

@dang update for typo?

@cbodley

This comment has been minimized.

Contributor

cbodley commented Mar 23, 2017

ping @dang

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Apr 26, 2017

@dang ping?

Document RGW quota cache options
Quota cache options were undocumented.

Fixes: http://tracker.ceph.com/issues/18747
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
@mattbenjamin

lgtm

@mattbenjamin mattbenjamin merged commit 126cd32 into ceph:master Jun 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment