Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: drop support for listing objects at a given snap #13398

merged 2 commits into from Feb 16, 2017


None yet
2 participants
Copy link

liewegas commented Feb 13, 2017

This was never used (Objecter is hard-coded to CEPH_NOSNAP for pg ops), is inefficient,
and a bad API for getting this info out of the OSD.

liewegas added some commits Feb 13, 2017

osd: drop pg_op_must_wait check
This made us wait if the snapid != CEPH_NOSNAP and there were any missing
objects at all.  Objecter can't submit such ops, and we're dropping support
for listing at a specific snap anyway.

Signed-off-by: Sage Weil <>
osd: drop unused+inefficient support for pg[n]ls at a specific snapid
This was super slow, and Objecter was incapable of generating the requests
to use it.

To do this properly we should create a new listing op that returns the
set of clones and/or snaps for each object as part of a single listing
result.  If/when the need arises.

Signed-off-by: Sage Weil <>

@liewegas liewegas requested a review from athanatos Feb 13, 2017

Copy link

gregsfortytwo left a comment

Reviewed-by: Greg Farnum

@liewegas liewegas merged commit fd39516 into ceph:master Feb 16, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Unmodifed Submodules submodules for project are unmodified
default Build finished.

@liewegas liewegas deleted the liewegas:wip-pgnls-snaps branch Feb 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.